SF-3618 Write permissions for new books on sync#3528
Merged
RaymondLuong3 merged 2 commits intomasterfrom Oct 28, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3528 +/- ##
==========================================
+ Coverage 82.22% 82.26% +0.04%
==========================================
Files 615 615
Lines 37053 37142 +89
Branches 6035 6076 +41
==========================================
+ Hits 30465 30554 +89
+ Misses 5701 5687 -14
- Partials 887 901 +14 ☔ View full report in Codecov by Sentry. |
pmachapman
force-pushed
the
fix/SF-3618
branch
from
b75fc23 to
328e9dd
Compare
pmachapman
changed the title
test/SIL.XForge.Scripture.Tests/Services/ParatextServiceTests.cs
Dismissed
Show dismissed
Hide dismissed
pmachapman
force-pushed
the
fix/SF-3618
branch
from
328e9dd to
0e80e1d
Compare
pmachapman
force-pushed
the
fix/SF-3618
branch
from
0e80e1d to
5a7da61
Compare
pmachapman
force-pushed
the
fix/SF-3618
branch
from
5a7da61 to
9e74fba
Compare
RaymondLuong3
temporarily deployed
to
e2e_tests
GitHub Actions
Inactive
RaymondLuong3
approved these changes
Oct 28, 2025
Collaborator
RaymondLuong3
left a comment
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pmachapman)
RaymondLuong3
force-pushed
the
fix/SF-3618
branch
from
9e74fba to
5cd2397
Compare
RaymondLuong3
temporarily deployed
to
e2e_tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows Administrators who do not have all access to books on a project to add drafts to it for books not currently in that project.
I have marked this PR as testing not required, as it is backend only, but if you want to test the change yourself, use the branch feature/SF-3567-frontend, which I have wired up to test this code (in a very basic manner).
An e2e test is sufficient for the changes to the sync runner, as these will only be triggered if a project has books created in SF not in PT.
This change is